Self-criticism, or negative self-evaluation characterized by often unrealistic personal standards and a harsh self-view, is a relevant transdiagnostic construct for mental health. Yet, the psychometric properties of scales assessing self-criticism have not been examined in military veterans, a population with a high burden of psychiatric symptoms. The present study tested the factor structure of the full and short-form versions of the Forms of Self-Criticizing/Attacking and Self-Reassuring Scale (FSCRS and FSCRS-SF), a measure of self-criticism, in a sample of 1,161 United States veterans who completed this and other measures as part of a larger study. Measurement invariance across men and women and associations with mental health symptoms, disordered eating, substance abuse, and self-directed violence were also examined. We found adequate support for two- and three-factor models and improved model fit with correlated residuals. Given theoretical and model fit considerations, measurement invariance was tested with the three-factor model. Both the FSCRS and FSCRS-SF were invariant across men and women. Women scored higher than men on the Hated Self (HS) and Inadequate Self (IS) subscales. HS and IS subscales scores were positively correlated with mental health constructs, whereas Reassured Self (RS) subscale scores were negatively correlated with these constructs. Overall, both the FSCRS and FSCRS-SF, when a briefer scale is preferred, appear appropriate for use in veterans. There are important gender differences in self-criticism that warrant further investigation; however, scores on this measure can be meaningfully compared across men and women. Validation of the FSCRS in veterans may encourage additional research on self-criticism in this population.